-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup HDF5 dataset without having data ahead of time #747
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #747 +/- ##
==========================================
+ Coverage 87.47% 87.57% +0.09%
==========================================
Files 44 44
Lines 8790 8834 +44
Branches 2023 2033 +10
==========================================
+ Hits 7689 7736 +47
+ Misses 786 784 -2
+ Partials 315 314 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall this looks good to me.
Co-authored-by: Oliver Ruebel <[email protected]>
Please fix flake8 changes and add a note to the changelog |
Co-authored-by: Ryan Ly <[email protected]>
Thanks. LGTM! |
Motivation
Add the ability to create a dataset on disk and get access to the handle to the dataset without having to close and repoen a file.
How to test the behavior?
Checklist
flake8
from the source directory.