frontend: Add websocket multiplexer #2563
Open
+589
−326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Backend Code coverage changed from 61.1% to 61.2%. Change: .1% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
a3b5f1f
to
e23dd95
Compare
dosubot
bot
added
the
size:XL
|
Backend Code coverage changed from 61.1% to 61.1%. Change: 0% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
e23dd95
to
af50857
Compare
|
Backend Code coverage changed from 61.0% to 61.2%. Change: .2% 😃. Coverage report |
|
Hi, I've tried the test case that you've described and it doesn't work for me. It enters some kind of loop and keeps rerendering pod-creation-loop.mp4Another thing I've tried is setting allowed namespaces (default and store) in setting
Then went to pods page and it connects to the first namespace twice, but should connect to both default and store
|
|
What is the purpose of the STATUS message? I don't see it being used on the frontend
|
|
So websocket connection can be of 4 types
|
sniok
requested changes
Nov 14, 2024
| */ | ||
| export function useWebSockets<T>({ | ||
| connections, | ||
| export function useWebSocket<T extends KubeObjectInterface>({ |
There was a problem hiding this comment.
we'll still need to have useWebSockets hook for listening to multiple connections
| if (token) { | ||
| const encodedToken = btoa(token).replace(/=/g, ''); | ||
| protocols.push(`base64url.bearer.authorization.k8s.io.${encodedToken}`); | ||
| class WebSocketManager { |
There was a problem hiding this comment.
some tests for this logic are needed
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
af50857
to
8484f79
Compare
|
Backend Code coverage changed from 61.1% to 61.2%. Change: .1% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
8484f79
to
146c4db
Compare
|
Backend Code coverage changed from 61.0% to 61.1%. Change: .1% 😃. Coverage report |
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
146c4db
to
6055579
Compare
|
Backend Code coverage changed from 61.0% to 61.2%. Change: .2% 😃. Coverage report |
This adds a single websocket connection from frontend to backend and sends lists of messages to the backend. With the help of messages backend creates multiple websocket connection to k8s API and returns back the data. This solves the issue for limiting of websocket connection in frontend in case of multi cluster setup. Signed-off-by: Kautilya Tripathi <[email protected]>
Now websocket has clear type that is needs to sends. This also fixes panic of websocket in various edge cases. Signed-off-by: Kautilya Tripathi <[email protected]>
knrt10
force-pushed
the
websocket-multiplexer-frontend
branch
from
6055579
to
091b60a
Compare
|
Backend Code coverage changed from 61.0% to 61.1%. Change: .1% 😃. Coverage report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a single websocket connection from frontend to backend and sends lists of messages to the backend. With the help of messages backend creates multiple websocket connection to k8s API and returns back the data.
This solves the issue for limiting of websocket connection in frontend in case of multi cluster setup.
Fixes: #2515
Testing
cd frontend && npm startcd backend && go run ./cmd -dev -enable-dynamic-clusterskubectl run nginx --image=nginxTODO