Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LANGUAGE] Colors in lists in non-English don't work #3356

Closed
Felienne opened this issue Sep 30, 2022 · 3 comments · Fixed by #4675 or #4756
Closed

[LANGUAGE] Colors in lists in non-English don't work #3356

Felienne opened this issue Sep 30, 2022 · 3 comments · Fixed by #4675 or #4756
Assignees
@Felienne @boryanagoncharenko
Labels
language Issues related to the Hedy language

Comments

@Felienne
Copy link
Member

Felienne commented Sep 30, 2022 •
edited
Loading

As mentioned in the recent turtle PR, colors in non-English don't work as well as they do in English.

In addition to that I also found that colors, especially those in lists, don't work when you're not using English color names. I don't know how easy/hard it is to solve that, but it should be a different ticket/PR.

Originally posted by @arjank in #3332 (comment)

This works in level 3, Dutch keywords but English color names:

image

lijstkleuren is white, pink, green, blue
kleur lijstkleuren at random
vooruit 150

But, with Dutch color names, the same does not work:
image

lijstkleuren is wit, roze, groen, blauw
kleur lijstkleuren at random
vooruit 150
@Felienne
Copy link
Member Author

Hi @arjank! I think this was the issue you meant on #3332 right?

@arjank
Copy link
Collaborator

arjank commented Oct 3, 2022

Yes, this is what I meant.

@Felienne Felienne added the language Issues related to the Hedy language label Sep 23, 2023
@Felienne Felienne self-assigned this Sep 23, 2023
@Felienne Felienne moved this to ToBeDiscussed in Hedy organization board Sep 23, 2023
@Felienne Felienne moved this from ToBeDiscussed to Long Term in Hedy organization board Sep 23, 2023
@Felienne Felienne moved this from Long Term to In Progress in Hedy organization board Oct 27, 2023
@Felienne Felienne mentioned this issue Oct 27, 2023
Merged
4 tasks
@Felienne Felienne moved this from In Progress to Done in Hedy organization board Nov 3, 2023
@Felienne Felienne reopened this Nov 14, 2023
@Felienne
Copy link
Member Author

Oops, the fix in #4675 caused #4752, so I am reverting that for now, will pick up the issue later in #4751 where I started the partial work

@Felienne Felienne mentioned this issue Nov 15, 2023
Merged
@mergify mergify bot closed this as completed in #4756 Nov 16, 2023
mergify bot pushed a commit that referenced this issue Nov 16, 2023
@Felienne
[LANGUAGE, FIX] Fix non-en colors in lists and ask (#4756)
70cf3f9 
Reverts #4754. This is a redo of #4675, which fixed #3356 but caused #4752.

This has additional commits that also fix #4752.

**Original text from #4675:**

**Description**

Allows the use of Dutch (and other langs) names in a list, fixing  #3356. This new way of processing numbers to English at runtime also allows for using non-English colors in an ask:

<img width="1608" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/fa373815-47d5-4e68-b50b-d69404082c6f">

This PR:
<img width="1592" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/07d0f3ee-e8aa-4407-ad5d-0660c651cba8">

main:
<img width="1422" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/c7a2d2e5-7c33-48a7-9b63-ce9b0182d932">

**Fixes #3356**

**How to test**

I added a test about the list access, for the ask issue, check that the images above work for you also.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Felienne Felienne

@boryanagoncharenko boryanagoncharenko

Labels
language Issues related to the Hedy language
Projects
None yet
Milestone
No milestone
3 participants
@arjank @Felienne @boryanagoncharenko