[LANGUAGE, FIX] Fix non-en colors in lists and ask #4675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 701e981.
This reverts commit 72f9178.
for more information, see https://pre-commit.ci
Felienne
changed the title
Felienne
changed the title
|
Oh no, conflicts 😭 |
|
How do we edit the exact same lines @jpelay?! I will pick these up! |
This was referenced Nov 14, 2023
Felienne
added a commit
that referenced
this pull request
Nov 14, 2023
Felienne
added a commit
that referenced
this pull request
Nov 15, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 16, 2023
Reverts #4754. This is a redo of #4675, which fixed #3356 but caused #4752. This has additional commits that also fix #4752. **Original text from #4675:** **Description** Allows the use of Dutch (and other langs) names in a list, fixing #3356. This new way of processing numbers to English at runtime also allows for using non-English colors in an ask: <img width="1608" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/fa373815-47d5-4e68-b50b-d69404082c6f"> This PR: <img width="1592" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/07d0f3ee-e8aa-4407-ad5d-0660c651cba8"> main: <img width="1422" alt="image" src="https://github.com/hedyorg/hedy/assets/1003685/c7a2d2e5-7c33-48a7-9b63-ce9b0182d932"> **Fixes #3356** **How to test** I added a test about the list access, for the ask issue, check that the images above work for you also.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows the use of Dutch (and other langs) names in a list, fixing #3356. This new way of processing numbers to English at runtime also allows for using non-English colors in an ask:
This PR:
main:
Fixes #3356
How to test
I added a test about the list access, for the ask issue, check that the images above work for you also.
Checklist
Done? Check if you have it all in place using this list: (mark with x if done)