Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI idea] change fa language icon into the used language #4835

Closed
Felienne opened this issue Dec 1, 2023 · 0 comments · Fixed by #5309
Closed

[UI idea] change fa language icon into the used language #4835

Felienne opened this issue Dec 1, 2023 · 0 comments · Fixed by #5309
Assignees
@Annelein

Comments

@Felienne
Copy link
Member

Felienne commented Dec 1, 2023

I already did this in: 9516f7f

But it has two limitations:

  1. [UI] Make keyword toggle also switcher language of the editor #4828 (comment) I think pybabel might have language abbreviations in the actual language? Someone must dive into that

  2. Somehow it starts at None? Should not be so hard to fix but needs a bit of debugging.
@Felienne Felienne moved this to ToBeDiscussed in Hedy organization board Mar 19, 2024
@Annelein Annelein mentioned this issue Mar 25, 2024
Merged
@Annelein Annelein moved this from ToBeDiscussed to Ready for Review in Hedy organization board Mar 25, 2024
@mergify mergify bot closed this as completed in #5309 Apr 1, 2024
mergify bot pushed a commit that referenced this issue Apr 1, 2024
@Annelein
💻 Language switcher text (#5309)
59f6474 
Fixes #4835 

[Babel](https://www.unicode.org/cldr/charts/44/supplemental/territory_language_information.html) only lists language codes in Latin alphabet. I did some searching and I think it would be quite difficult to find the non Latin language codes. So for the non Latin languages, I thought the best solution would be to just state the _non Latin language_ in the switcher instead of the _non Latin language code._ 

**How to test**
1. Select a non latin language in your profile
2. Go to Hedy
3. Check if there is a language in the switcher (and it's not None)
4. Switch between English and the (non Latin) language

https://github.com/hedyorg/hedy/assets/48122190/73adcb1c-fefb-42f3-958d-3876dbf6eb7b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Annelein Annelein

Labels
None yet
Projects
Hedy organization board
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

💻 Language switcher text hedyorg/hedy
2 participants
@Felienne @Annelein