💻 Language switcher text #5309
Merged
💻 Language switcher text #5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Felienne
reviewed
Mar 31, 2024
| @@ -414,6 +415,9 @@ def setup_language(): | |||
| # front-end is fixed based on this value | |||
| g.dir = static_babel_content.TEXT_DIRECTIONS.get(g.lang, 'ltr') | |||
|
|
|||
| # True if it is a Latin alphabet, False if not | |||
There was a problem hiding this comment.
Love this comment! This is exactly the type of thing that is very easy to understand/explain and superhard to get from the code!
Felienne
approved these changes
Apr 1, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4835
Babel only lists language codes in Latin alphabet. I did some searching and I think it would be quite difficult to find the non Latin language codes. So for the non Latin languages, I thought the best solution would be to just state the non Latin language in the switcher instead of the non Latin language code.
How to test
Screen.Recording.2024-03-25.at.15.23.18.mov