Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] Remove start_codes, load code in slides differently #4906

Closed
Felienne opened this issue Dec 14, 2023 Discussed in #4837 · 0 comments · Fixed by #4913
Closed

[CONTENT] Remove start_codes, load code in slides differently #4906

Felienne opened this issue Dec 14, 2023 Discussed in #4837 · 0 comments · Fixed by #4913
Assignees

Comments

@Felienne
Copy link
Member

Discussed in #4837

Originally posted by Felienne December 1, 2023
All adventures currently have a field start_code, see:

start_code: '{print} Your story starts here'

This is a bit of legacy content, as I have said before, I only realised after a long while that we are building a system for teaching programming, not a system for kids to learn or explore programming alone. These start codes are very old, when we (I) thought that every level would just have a start code and kids would append and explore alone. But our preferred workflow for kids now is to read the exercise, take the startcode from the exercise, and change that!

So, there are a number of reasons to get rid of these start codes now:

  • They are not useful anymore; the workflow is based on exercises (see above)
  • They are adding a lot of translation efforts! Since we have to translate all of them separately. '# place your code here' occurs 73 times in en.yaml and has to be translated each time!

So, let's remove them from the content files!

@Felienne Felienne self-assigned this Dec 14, 2023
mergify bot pushed a commit that referenced this issue Dec 17, 2023
Addressed the first part of #4906 by loading code into the slides, rather than loading start codes. I again have learned a valuable lesson here haha. I though "ah I will just half-ass the slides a bit by repurposing something existing, and I will improve it later" and then of course slides are expanded and translated and it gets harder and harder to still improve. I keep forgetting this is not my tiny hobby project anymore :) 

**How to test**
Go to the slides and see that code is loaded from the yaml files.


This also fixes #4794 since it is no longer needed to look up slides code.
@mergify mergify bot closed this as completed in #4913 Dec 18, 2023
mergify bot pushed a commit that referenced this issue Dec 18, 2023
Fixes #4906 by removing all start_codes and associated test code and validation.

**How to test**
Verify that everything works without using start_codes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant