Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CONTENT] Remove start codes #4913

Merged
merged 16 commits into from
Dec 18, 2023
Merged

[CONTENT] Remove start codes #4913

merged 16 commits into from
Dec 18, 2023

Conversation

Felienne
Copy link
Member

@Felienne Felienne commented Dec 17, 2023

Fixes #4906 by removing all start_codes and associated test code and validation.

How to test
Verify that everything works without using start_codes

@ghost
Copy link

ghost commented Dec 17, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@Felienne Felienne marked this pull request as ready for review December 17, 2023 11:20
@Felienne
Copy link
Member Author

Dropping the current Weblate stats from the readme here because I want to see the impact on the percentages after merge :)

image

@Felienne
Copy link
Member Author

Felienne commented Dec 18, 2023

Hi @SabinaChita!

This is a small change in content, but it will have quite an impact on teaching, I suspect! Here are some ideas to place in the newsletter, feel free to adapt where needed, the headers are more for you that to be placed in the newsletter like this! The screenshots are also for you, I can imagine we will make other ones for the newsletter.

How it used to work
All levels used to have a start_code, if you go to a new adventure, code would be shown in the editor:

image

How it works now
There are no more start_codes, so if you go to a new tab now, where you have never created something, the editor box will be empty:

image

Why
Since we have the exercises now, we want kids to start from the exercise code, run that and follow the exercise. So the start code is more a distraction than helpful.

Potential impact on teaching
I suspect that a lot of kids in the current start just run the start code and are happy everything is working. Teachers might have to work a little bit harder to get kids to get started, but this will be worth it hopefully since it focuses their attention on the exercise.

Copy link
Contributor

mergify bot commented Dec 18, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit aec7dee into main Dec 18, 2023
11 checks passed
@mergify mergify bot deleted the remove-start-main branch December 18, 2023 11:53
mergify bot pushed a commit that referenced this pull request Dec 18, 2023
Oops, my genius regex used in #4913 missed a few start_codes! This catches and removes them all 

**How to test**
Please verify that there are no more occurrences of start_code in the adventure yamls
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

[CONTENT] Remove start_codes, load code in slides differently
2 participants