Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 🎶 Skip front-end warning for music #5000

Closed
Felienne opened this issue Jan 18, 2024 · 0 comments · Fixed by #5488
Closed

🪲 🎶 Skip front-end warning for music #5000

Felienne opened this issue Jan 18, 2024 · 0 comments · Fixed by #5488
Assignees
@Felienne
Labels
bug Something isn't working

Comments

@Felienne
Copy link
Member

Describe the bug
Error is still shown:

image

I thought I fixed this but alas!
@Felienne Felienne added the bug Something isn't working label Jan 18, 2024
@Felienne Felienne self-assigned this Jan 18, 2024
@Felienne Felienne mentioned this issue Feb 7, 2024
Closed
@LiberCas LiberCas mentioned this issue Apr 29, 2024
Merged
@mergify mergify bot closed this as completed in #5488 Apr 30, 2024
mergify bot pushed a commit that referenced this issue Apr 30, 2024
@LiberCas
🪲 Fix front-end print statement missing warning for music (#5488)
d681b15 
This PR solves the issue of warning messages appearing on music adventures when no print statement is present

In spite of not requiring print statements to output, until now submitting a piece of code to a music adventure without including a print statement would result in a warning such as in the following example:

![Warning appears in music](https://github.com/hedyorg/hedy/assets/75997357/33c07cd9-65aa-4b4b-9f07-b39e078f0d3a)


I have solved the issue by checking whether the adventure has any music before issuing the warning in a similar manner to what is done with adventures including turtles


Fixes [#5000](#5000)

**How to test**

Follow these steps to verify this PR works as intended:
* Go to [http://localhost:8080/hedy/1#music](http://localhost:8080/hedy/1#music)
* Type:
```
play C4
```
*Check that no warning appears:

![Warning no longer appears in music](https://github.com/hedyorg/hedy/assets/75997357/7b25bebe-0f52-45c8-b9fb-08e5c8615e4d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Felienne Felienne

Labels
bug Something isn't working
Projects
Hedy organization board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪲 Fix front-end print statement missing warning for music JoseArtur/hedy
1 participant
@Felienne