Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🪲 Fix front-end print statement missing warning for music #5488

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

LiberCas
Copy link
Contributor

This PR solves the issue of warning messages appearing on music adventures when no print statement is present

In spite of not requiring print statements to output, until now submitting a piece of code to a music adventure without including a print statement would result in a warning such as in the following example:

Warning appears in music

I have solved the issue by checking whether the adventure has any music before issuing the warning in a similar manner to what is done with adventures including turtles

Fixes #5000

How to test

Follow these steps to verify this PR works as intended:

play C4

*Check that no warning appears:

Warning no longer appears in music

Copy link
Member

@Felienne Felienne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your first Hedy PR @LiberCas!! Welcome to the team.

Let us know if you want to pick up other things (are you on the Discord yet?)

@Felienne Felienne changed the title Solving a bug related with front-end print statement missing warning for music 🪲 Fix front-end print statement missing warning for music Apr 30, 2024
Copy link
Contributor

mergify bot commented Apr 30, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d681b15 into hedyorg:main Apr 30, 2024
10 checks passed
@LiberCas
Copy link
Contributor Author

LiberCas commented May 2, 2024

You're welcome @Felienne, it's been a pleasure to help!

I'm in university right now so I don't have much time, but when summer vacation comes up I might be able to give you guys a more active hand.

Love the project btw❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🪲 🎶 Skip front-end warning for music
2 participants