Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 Console errors related to user activity #5550

Closed
jpelay opened this issue May 21, 2024 · 4 comments · Fixed by #5599
Closed

🪲 Console errors related to user activity #5550

jpelay opened this issue May 21, 2024 · 4 comments · Fixed by #5599
Assignees
@Annelein
Labels
bug Something isn't working

Comments

@jpelay
Copy link
Member

jpelay commented May 21, 2024 •
edited
Loading

This is happening on alpha right now, we are getting console errors related to some JSON. I checked the response that is being turned to json and it seemed fine, does anyone else have any clue?

image
@jpelay jpelay added the bug Something isn't working label May 21, 2024
@jpelay
Copy link
Member Author

jpelay commented May 21, 2024

Tagging @hasan-sh!

@hasan-sh
Copy link
Collaborator

hasan-sh commented May 22, 2024 •
edited
Loading

Fixed by #5527

@jpelay
Copy link
Member Author

jpelay commented May 22, 2024

Fixed by #5527

I don't think it is! As I see it, the error is not the same? Now it says "Unexpected end of JSON input".

@Annelein
Copy link
Collaborator

Annelein commented Jun 3, 2024

@hasan-sh it would be nice to have it fixed because it's quite an annoying bug when debugging!

@Annelein Annelein assigned hasan-sh and Annelein and unassigned hasan-sh Jun 3, 2024
@Annelein Annelein mentioned this issue Jun 7, 2024
Merged
@Annelein Annelein moved this to Ready for Review in Hedy organization board Jun 9, 2024
@mergify mergify bot closed this as completed in #5599 Jun 10, 2024
mergify bot pushed a commit that referenced this issue Jun 10, 2024
@jpelay
🪲 Fix make_response incorrectly sending text instead of JSON (#5599)
f24810f 
#5558 Introduced an error where some calls where expecting a JSON, and got text instead. I checked the places where this happened and fix the calls. 

If I'm missing some, please add them 😄 

**How to test**
Perform the following: 

* Update an adventure
* Update  a class customization
* Create students account
* Reset password
* Reset a student's password
* Update your public profile

And all of them should show the success modal! 

Also:
Fixes #5550
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Annelein Annelein

Labels
bug Something isn't working
Projects
Hedy organization board
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

🪲 Fix make_response incorrectly sending text instead of JSON hedyorg/hedy
3 participants
@hasan-sh @jpelay @Annelein