🧹 Remove debug prints that were left in and fix debug logging #5527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The user activity tracking code logs a lot of errors to the JavaScript console. Nothing goes wrong, but the `postJson` function that is begin used expects a `200` response, but is getting a `204` response. Only signal an error if we actually get a `400` or higher response. Also remove some Python `print()`s that were left in most likely for debugging.
hasan-sh
approved these changes
May 14, 2024
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user activity tracking code logs a lot of errors to the JavaScript console. Nothing goes wrong, but the
postJsonfunction that is begin used expects a200response, but is getting a204response.Only signal an error if we actually get a
400or higher response.Also remove some Python
print()s that were left in most likely for debugging.How to test
Open the console, use the website, observe that the following error does not appear: