-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG FIX] Fix embedded editor with CodeMirror #4821
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @TiBiBa!! Sorry! I forgot about applying the CodeMirror change here.
Can this editor grow larger than 352px? If so I think we need to change a few things
No problem! The height might be an issue in some cases (we don't know the situations the editor will be embedded). But most urgent it that it currently isn't working at all. Maybe merge this and make a new issue for the height? |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Yeah! Approved this and opened #4841 so we don't forget. |
Description
In this PR we fix some issues that were the result of the migration from ace to CodeMirror. The embedded editor view was not updated yet and still relied on the ace editor. This resulted in some rendering and postMessage issues, making it unusable when embedding.
Fixes issue or discussion number
This PR fixes #4820
How to test
Navigate to the following link when running locally, all should work as expected:
http://127.0.0.1:8080/1/?lang=nl&run=true&readOnly=false&program=cHJpbnQgaGFsbG8gd2VyZWxkIQ==