Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG FIX] Fix embedded editor with CodeMirror #4821

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Conversation

TiBiBa
Copy link
Collaborator

@TiBiBa TiBiBa commented Nov 29, 2023

Description
In this PR we fix some issues that were the result of the migration from ace to CodeMirror. The embedded editor view was not updated yet and still relied on the ace editor. This resulted in some rendering and postMessage issues, making it unusable when embedding.

Fixes issue or discussion number
This PR fixes #4820

How to test
Navigate to the following link when running locally, all should work as expected:

http://127.0.0.1:8080/1/?lang=nl&run=true&readOnly=false&program=cHJpbnQgaGFsbG8gd2VyZWxkIQ==

@TiBiBa TiBiBa changed the title [BUG FIX] Fix embedded editor with CodeMirropr [BUG FIX] Fix embedded editor with CodeMirror Nov 29, 2023
@TiBiBa TiBiBa marked this pull request as draft November 29, 2023 09:37
@ghost
Copy link

ghost commented Nov 29, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@TiBiBa TiBiBa marked this pull request as ready for review November 29, 2023 09:55
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @TiBiBa!! Sorry! I forgot about applying the CodeMirror change here.

Can this editor grow larger than 352px? If so I think we need to change a few things
image

@TiBiBa
Copy link
Collaborator Author

TiBiBa commented Dec 1, 2023

Hi @TiBiBa!! Sorry! I forgot about applying the CodeMirror change here.

Can this editor grow larger than 352px? If so I think we need to change a few things image

No problem! The height might be an issue in some cases (we don't know the situations the editor will be embedded). But most urgent it that it currently isn't working at all. Maybe merge this and make a new issue for the height?

Copy link
Contributor

mergify bot commented Dec 1, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c44b710 into main Dec 1, 2023
11 checks passed
@mergify mergify bot deleted the fix-embedded-editor branch December 1, 2023 20:50
@jpelay
Copy link
Member

jpelay commented Dec 1, 2023

No problem! The height might be an issue in some cases (we don't know the situations the editor will be embedded). But most urgent it that it currently isn't working at all. Maybe merge this and make a new issue for the height?

Yeah! Approved this and opened #4841 so we don't forget.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] CodeMirror change broke the embedded editor
2 participants