Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI idea] Improve resizing of CodeMirror #4841

Closed
jpelay opened this issue Dec 1, 2023 · 0 comments · Fixed by #4871
Closed

[UI idea] Improve resizing of CodeMirror #4841

jpelay opened this issue Dec 1, 2023 · 0 comments · Fixed by #4871
Assignees
@jpelay

Comments

@jpelay
Copy link
Member

jpelay commented Dec 1, 2023

Using a hard coded pixel height is causing issues on the embedded editor. There must be a way to this automatically!
@jpelay jpelay self-assigned this Dec 1, 2023
This was referenced Dec 1, 2023
Merged
Merged
@mergify mergify bot closed this as completed in #4871 Dec 8, 2023
mergify bot pushed a commit that referenced this issue Dec 8, 2023
@jpelay
[FIX, UI] Editor size depending on parent (#4871)
0aef722 
**Description**

Sets the size of the editor depending on its parent, `#editor`, when creating it. Also changes the implementation of the `resize` function to change the `height` of the `style` property of the editor's dom element, this simplifies the constructor a little bit. 

**Fixes #4841 and fixes #4866 (because that the buttons weren't shown was actually a fault of this) **

**How to test**

* Go to the slides and see that the editor is shown correctly
* Go to: http://0.0.0.0:8080/embedded/1/?lang=nl&run=true&readOnly=false&program=cHJpbnQgaGFsbG8gd2VyZWxkIQ==

And check that the editor takes the entire space.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpelay jpelay

Labels
None yet
Projects
Hedy organization board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[FIX, UI] Editor size depending on parent jpelay/hedy
1 participant
@jpelay