Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX, UI] Editor size depending on parent #4871

Merged
merged 6 commits into from
Dec 8, 2023

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Dec 7, 2023

Description

Sets the size of the editor depending on its parent, #editor, when creating it. Also changes the implementation of the resize function to change the height of the style property of the editor's dom element, this simplifies the constructor a little bit.

**Fixes #4841 and fixes #4866 (because that the buttons weren't shown was actually a fault of this) **

How to test

And check that the editor takes the entire space.

@jpelay jpelay requested a review from TiBiBa December 7, 2023 23:11
@jpelay
Copy link
Member Author

jpelay commented Dec 7, 2023

Hi @TiBiBa, this will change the initial size of the embedded editor, can you check that it doesn't break something on your side? And if it does, please do tell me!

@Felienne
Copy link
Member

Felienne commented Dec 8, 2023

Solves the slides issue:

image

Leaving the final ok to @TiBiBa so he can check the embedded editor!

@TiBiBa
Copy link
Collaborator

TiBiBa commented Dec 8, 2023

Will check this!

Copy link
Contributor

mergify bot commented Dec 8, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 8, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 0aef722 into hedyorg:main Dec 8, 2023
9 checks passed
Copy link
Contributor

mergify bot commented Dec 8, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Run code button on the slides is hidden by input field [UI idea] Improve resizing of CodeMirror
3 participants