-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX, UI] Editor size depending on parent #4871
Conversation
Hi @TiBiBa, this will change the initial size of the embedded editor, can you check that it doesn't break something on your side? And if it does, please do tell me! |
Solves the slides issue: Leaving the final ok to @TiBiBa so he can check the embedded editor! |
Will check this! |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Description
Sets the size of the editor depending on its parent,
#editor
, when creating it. Also changes the implementation of theresize
function to change theheight
of thestyle
property of the editor's dom element, this simplifies the constructor a little bit.**Fixes #4841 and fixes #4866 (because that the buttons weren't shown was actually a fault of this) **
How to test
And check that the editor takes the entire space.