-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
💻 Add sleep prompt until level 7 #5277
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi!! Good job Annelein, it does work when I supply a number to the sleep command, but not a variable! It'd be nice if it also worked with them.
Didn't think of it at all haha, thanks! Added it |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Hi Annelein! Thanks for solving the variable issue. Now it does work with variables, but I tested it in further levels and found a few other bugs:
|
for more information, see https://pre-commit.ci
Points 1 and 2 are solved, for point 3, after level 7 it gets a lot more complicated to run the sleep prompt in order, so the prompt is only shown until level 7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work Annelein!! Thanks so much for addressing my comments.
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #4769
After level 7 'if' statements are possible and it gets a lot more complicated to run the sleep prompt in order.
Screen.Recording.2024-03-18.at.15.31.27.mov