Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💻 Add sleep prompt until level 7 #5277

Merged
merged 23 commits into from
Mar 21, 2024
Merged

💻 Add sleep prompt until level 7 #5277

merged 23 commits into from
Mar 21, 2024

Conversation

Annelein
Copy link
Collaborator

@Annelein Annelein commented Mar 18, 2024

Fixes #4769

After level 7 'if' statements are possible and it gets a lot more complicated to run the sleep prompt in order.

Screen.Recording.2024-03-18.at.15.31.27.mov

@jpelay jpelay self-assigned this Mar 19, 2024
Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi!! Good job Annelein, it does work when I supply a number to the sleep command, but not a variable! It'd be nice if it also worked with them.

@Annelein
Copy link
Collaborator Author

Hi!! Good job Annelein, it does work when I supply a number to the sleep command, but not a variable! It'd be nice if it also worked with them.

Didn't think of it at all haha, thanks! Added it

@jpelay
Copy link
Member

jpelay commented Mar 19, 2024

Hi Annelein! Thanks for solving the variable issue. Now it does work with variables, but I tested it in further levels and found a few other bugs:

  1. Only writing sleep does not show the modal. For example this program on level 2.
sleep
print hello
  1. If I have 2 sleeps, only the first one will have a modal. For example this program on level 2:
print hello world
sleep 1
print after sleep 1
sleep 1
print after sleep 2
  1. From level 8 onwards the sleep modal is shown even if the sleep instruction hasn't been reached yet, for example this program:
name = ask 'What is your name?'
if name is Hedy
    print 'Welcome Hedy'
    print 'You can play on your computer!'
    sleep 1
    print 'after sleep'

@Annelein Annelein changed the title 💻 Add sleep prompt 💻 Add sleep prompt until level 7 Mar 20, 2024
@Annelein Annelein requested a review from jpelay March 20, 2024 15:18
@Annelein
Copy link
Collaborator Author

Points 1 and 2 are solved, for point 3, after level 7 it gets a lot more complicated to run the sleep prompt in order, so the prompt is only shown until level 7

Copy link
Member

@jpelay jpelay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Annelein!! Thanks so much for addressing my comments.

Copy link
Contributor

mergify bot commented Mar 21, 2024

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 5f264c5 into main Mar 21, 2024
12 checks passed
@mergify mergify bot deleted the sleep-prompt branch March 21, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[UI idea] Show sleeping state
2 participants