🪲 Improve long program warning for sleep programs and increase time #5576
Conversation
…into improve-long-program
|
Hi @Annelein! I think I made the frontend fix correctly but I am not sure, can you check and approve if this makes sense (and improve otherwise 🤣 ) |
Felienne
changed the title
for more information, see https://pre-commit.ci
| response['variables'] = transpile_result.roles_of_variables | ||
| except Exception: | ||
| pass | ||
|
|
||
| if level < 7: |
There was a problem hiding this comment.
This if needs to go in any case, because otherwise has_sleep will never be set on programs above 7, but I am not sure what to do with the rest.
It is a bit of magic why we need to send the list of sleep lengths to the frontend. If needed, I can probably get them from the parser, but you don't always know upfront how long they will be (it a variable is involved)
I am not even sure we need all of this complex code for the sleep prompt?
I think we could do it a lot easier in the Skulpt execution? Because I am sure the interpreter knows when to sleep?
There was a problem hiding this comment.
I think I prefer to ship this as we have it now, and ask Jesus (in due time) to solve this in the interpreter, because this is annoying people.
Yeah I figured that! it was smartly done working around the parser like that! If will you are ok with merging this, I will re-open the sleep prompt one and we will ask Jesus to do it with Skulpt! |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Fixes #5399
In #5277 we introduced a sleep prompt, but accidentally we now now longer detect sleeps in levels below 7, causing them to quickly stop (annoying!) Maybe that was even the reason people were reporting #5399 but I upped the limits a bit too.