Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🪲 Fix front-end print statement missing warning for music #5488

Merged
merged 4 commits into from
Apr 30, 2024
Merged

🪲 Fix front-end print statement missing warning for music #5488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b40298e
Missing print statement warning no longer appears for music adventures
LiberCas Apr 29, 2024
32ae296
🤖 Automatically update generated files
LiberCas Apr 29, 2024
6879b2b
Merge branch 'main' into pr/5488
Felienne Apr 30, 2024
1fbc988
🤖 Automatically update generated files
Felienne Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion static/js/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1097,7 +1097,7 @@ export function runPythonProgram(this: any, code: string, sourceMap: any, hasTur
}

// Check if the program was correct but the output window is empty: Return a warning
if ((!hasClear) && $('#output').is(':empty') && $('#turtlecanvas').is(':empty')) {
if ((!hasClear) && $('#output').is(':empty') && $('#turtlecanvas').is(':empty') && !hasMusic) {
pushAchievement("error_or_empty");
error.showWarning(ClientMessages['Transpile_warning'], ClientMessages['Empty_output']);
return;
Expand Down
2 changes: 1 addition & 1 deletion static/js/appbundle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99826,7 +99826,7 @@ def note_with_error(value, err):
if (hasTurtle) {
$("#saveFilesContainer").show();
}
if (!hasClear && $("#output").is(":empty") && $("#turtlecanvas").is(":empty")) {
if (!hasClear && $("#output").is(":empty") && $("#turtlecanvas").is(":empty") && !hasMusic) {
pushAchievement("error_or_empty");
error.showWarning(ClientMessages["Transpile_warning"], ClientMessages["Empty_output"]);
return;
Expand Down
4 changes: 2 additions & 2 deletions static/js/appbundle.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading