You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've noticed for some time that I routinely see sets of paired portrait images showing up inside the configured recent_n window when neither of them should be there based on their age.
For example, I have my recent_n set to 1 day, so I can see the images I've added in the last 24 hours at the start of my slideshow (while building up the slideshow). However, in the group of new images, I routinely see sets of portrait images that haven't been added in the last 24 hours. While it's not a big deal, it definitely feels like a bug. I've always imagined it was somehow related to a subtle issue with the selection filter but I never really looked into it.
Poking around this evening, I found the cause, and it's much simpler. It's related to how we build the image list when the portrait pairs feature is active. While it's somewhat difficult (and probably unnecessary) to describe the underlying cause, it looks easy to fix.
I'll submit a PR as soon as I've tested the (rather simple) change.
The text was updated successfully, but these errors were encountered:
I'll likely merge this into dev sometime this evening unless anyone plans to test it independently. I'm happy to wait if that's the case - just let me know.
I've noticed for some time that I routinely see sets of paired portrait images showing up inside the configured
recent_n
window when neither of them should be there based on their age.For example, I have my
recent_n
set to 1 day, so I can see the images I've added in the last 24 hours at the start of my slideshow (while building up the slideshow). However, in the group of new images, I routinely see sets of portrait images that haven't been added in the last 24 hours. While it's not a big deal, it definitely feels like a bug. I've always imagined it was somehow related to a subtle issue with the selection filter but I never really looked into it.Poking around this evening, I found the cause, and it's much simpler. It's related to how we build the image list when the portrait pairs feature is active. While it's somewhat difficult (and probably unnecessary) to describe the underlying cause, it looks easy to fix.
I'll submit a PR as soon as I've tested the (rather simple) change.
The text was updated successfully, but these errors were encountered: