Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Older portrait images are incorrectly shown inside the "recent_n" window #144

Closed
jgodfrey opened this issue Jul 12, 2021 · 2 comments · Fixed by #145
Closed

Older portrait images are incorrectly shown inside the "recent_n" window #144

jgodfrey opened this issue Jul 12, 2021 · 2 comments · Fixed by #145
Assignees
Labels
bug Something isn't working

Comments

@jgodfrey
Copy link
Collaborator

I've noticed for some time that I routinely see sets of paired portrait images showing up inside the configured recent_n window when neither of them should be there based on their age.

For example, I have my recent_n set to 1 day, so I can see the images I've added in the last 24 hours at the start of my slideshow (while building up the slideshow). However, in the group of new images, I routinely see sets of portrait images that haven't been added in the last 24 hours. While it's not a big deal, it definitely feels like a bug. I've always imagined it was somehow related to a subtle issue with the selection filter but I never really looked into it.

Poking around this evening, I found the cause, and it's much simpler. It's related to how we build the image list when the portrait pairs feature is active. While it's somewhat difficult (and probably unnecessary) to describe the underlying cause, it looks easy to fix.

I'll submit a PR as soon as I've tested the (rather simple) change.

@jgodfrey jgodfrey self-assigned this Jul 12, 2021
@jgodfrey jgodfrey added the bug Something isn't working label Jul 12, 2021
@jgodfrey
Copy link
Collaborator Author

Fixed in PR #145. I'll wait to merge in case anyone wants to test.

@jgodfrey jgodfrey linked a pull request Jul 12, 2021 that will close this issue
@jgodfrey
Copy link
Collaborator Author

jgodfrey commented Jul 13, 2021

I'll likely merge this into dev sometime this evening unless anyone plans to test it independently. I'm happy to wait if that's the case - just let me know.

jgodfrey added a commit that referenced this issue Jul 13, 2021
…images-inside-recent_n-window

Fix issue #144, older portrait images inside recent_n window
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant