Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #144, older portrait images inside recent_n window #145

Merged
merged 3 commits into from
Jul 13, 2021
Merged

Fix issue #144, older portrait images inside recent_n window #145

merged 3 commits into from
Jul 13, 2021

Conversation

jgodfrey
Copy link
Collaborator

  • When buildling the image list returned from query_cache, each time a
    portrait set is paired, the next available "portrait slot" in the processed
    image list should be skipped. Without this, older portrait images will
    be promoted inside the recent_n boundary, even though they don't belong.

@jgodfrey
Fix issue #119 and issue #139
5e0a532 
- Refactor model.get_next_file() to...
  - Fix issue #119, deleted images cause slideshow glitch
  - Fix issue #139, image displayed an extra time during single playlist pass
@jgodfrey
Fix bug in no-files state update
501996d 
- When "no files" image is displayed, set the reload_files flag so we'll check
  for new files on the next pass. Otherwise, the "no files" image is permanently
  displayed, even when new images become available.
@jgodfrey
Fix Issue 144 - Older portrait images inside recent_n window
9eb26bb 
- When buildling the image list returned from query_cache, each time a
   portrait set is paired, the next available "portrait slot" in the processed
   image list should be skipped. Without this, older portrait images will
   be promoted inside the recent_n boundary, even though they don't belong.
@jgodfrey jgodfrey mentioned this pull request Jul 12, 2021
Closed
@jgodfrey jgodfrey linked an issue Jul 12, 2021 that may be closed by this pull request
Older portrait images are incorrectly shown inside the "recent_n" window #144
Closed
@jgodfrey jgodfrey changed the title Fix issue 144, older portrait images inside recent_n window Fix issue #144, older portrait images inside recent_n window Jul 13, 2021
@jgodfrey jgodfrey merged commit cf764fe into dev Jul 13, 2021
@jgodfrey jgodfrey deleted the Fix-issue-144,-older-portrait-images-inside-recent_n-window branch July 13, 2021 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Older portrait images are incorrectly shown inside the "recent_n" window
1 participant
@jgodfrey