Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gateway to packet_router_packet_down_v1 #316

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add gateway to packet_router_packet_down_v1 #316

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/service/packet_router.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ message packet_router_packet_down_v1 {
bytes payload = 1;
window_v1 rx1 = 2;
window_v1 rx2 = 3;
bytes gateway = 4;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why add this overhead to every packet headed to the gateway?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is an experiment to handle data from Router to HPR with less streams.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha but it’s also the proto message that the gateway receives right? If so you may want to put the downlink packet in an envelope with the gateway in the outer envelope

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could leave it empty when it goes to gateway

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like that breaks some system boundaries in favor of some optimization. Let’s chat this through before nailing it down

}

message envelope_down_v1 {
Expand Down