Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix 23.03 crashes when user tries to open it from suspended state (fg, bg) #6725

Closed
HellConnector opened this issue Apr 12, 2023 · 0 comments · Fixed by #6764
Closed

Helix 23.03 crashes when user tries to open it from suspended state (fg, bg) #6725

HellConnector opened this issue Apr 12, 2023 · 0 comments · Fixed by #6764
Labels
C-bug Category: This is a bug

Comments

@HellConnector
Copy link

Summary

When i need to suspend hx and go back to the terminal, i press ctrl-z, and helix suspended well. But if i execute bg and then fg in the terminal, helix just crashes.

image

Reproduction Steps

I tried this:

  1. hx
  2. ctrl-z
  3. bg
  4. fg

I expected this to happen: hx opens normally at the state it was suspended

Instead, this happened:
image

Helix log

~/.cache/helix/helix.log
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 4, kind: Interrupted, message: "Interrupted system call" }', /private/tmp/helix-20230331-6480-2cxefw/helix-term/src/application.rs:474:41
stack backtrace:
   0:        0x10ff427aa - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::h7ccb0a5911308a20
   1:        0x10f5bca7a - core::fmt::write::h8158d95376d3ffd4
   2:        0x10ff1d4cc - std::io::Write::write_fmt::h906cad35a9503f97
   3:        0x10ff42590 - std::sys_common::backtrace::print::h699856dda992f2e1
   4:        0x10ff244f3 - std::panicking::default_hook::{{closure}}::h66a03b3c8979fdca
   5:        0x10ff24205 - std::panicking::default_hook::hb24853726d3292d6
   6:        0x10ff24d07 - std::panicking::rust_panic_with_hook::h537956d5b9d077ec
   7:        0x10ff43975 - std::panicking::begin_panic_handler::{{closure}}::hf37433418b0d1181
   8:        0x10ff428f8 - std::sys_common::backtrace::__rust_end_short_backtrace::h56b0b14822285f07
   9:        0x10ff24862 - _rust_begin_unwind
  10:        0x1100149a3 - core::panicking::panic_fmt::h02cf2d7d99f4ebb0
  11:        0x110014e15 - core::result::unwrap_failed::h010baac391a0d5e7
  12:        0x10fd9cee7 - hx::main_impl::{{closure}}::h343d55024a01718d
  13:        0x10fd972ae - tokio::runtime::context::BlockingRegionGuard::block_on::hff5affa2209f1974
  14:        0x10fdaf1a5 - tokio::runtime::runtime::Runtime::block_on::h84de063ec8f2b42d
  15:        0x10fdc3f3c - hx::main::hf5ae25604e3759ea
  16:        0x10fd8b4d6 - std::sys_common::backtrace::__rust_begin_short_backtrace::h9c1b742ae9f966fe
  17:        0x10fda3d61 - std::rt::lang_start::{{closure}}::h666681958096d371
  18:        0x10ff2259c - std::rt::lang_start_internal::h0219f3c87928bec4
  19:        0x10fdc402c - _main
  20:     0x7ff8166cb41f - <unknown>

Platform

macOS

Terminal Emulator

alacritty 0.11

Helix Version

helix 23.03 (3cf0372)

@HellConnector HellConnector added the C-bug Category: This is a bug label Apr 12, 2023
@HellConnector HellConnector changed the title Helix 23.03 error when user try to open it from suspended state (fg, bg) Helix 23.03 crashes when user tries to open it from suspended state (fg, bg) Apr 13, 2023
h1t added a commit to h1t/helix that referenced this issue Apr 15, 2023
pascalkuthe pushed a commit that referenced this issue Apr 16, 2023
* Fix crash on opening from suspend state (#6725)

* Fix code style

* revert using of the imperative code style. Add panic if couldn't set terminal raw mode

* remove redundant import of core::panic macros

* small refactoring
Triton171 pushed a commit to Triton171/helix that referenced this issue Jun 18, 2023
* Fix crash on opening from suspend state (helix-editor#6725)

* Fix code style

* revert using of the imperative code style. Add panic if couldn't set terminal raw mode

* remove redundant import of core::panic macros

* small refactoring
wes-adams pushed a commit to wes-adams/helix that referenced this issue Jul 4, 2023
* Fix crash on opening from suspend state (helix-editor#6725)

* Fix code style

* revert using of the imperative code style. Add panic if couldn't set terminal raw mode

* remove redundant import of core::panic macros

* small refactoring
smortime pushed a commit to smortime/helix that referenced this issue Jul 10, 2024
* Fix crash on opening from suspend state (helix-editor#6725)

* Fix code style

* revert using of the imperative code style. Add panic if couldn't set terminal raw mode

* remove redundant import of core::panic macros

* small refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant