Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on opening from suspend state #6764

Merged

Conversation

h1t
Copy link
Contributor

@h1t h1t commented Apr 15, 2023

Fixes #6725

This commit is copy/paste from same issue of neovim:

@the-mikedavis the-mikedavis self-requested a review April 15, 2023 15:02
@h1t h1t requested a review from kareigu April 15, 2023 20:00
@pascalkuthe
Copy link
Member

also shouldn't we still panic if claim_term fails all retries? Currently we just silently continue in that case which we really shouldn't

pascalkuthe
pascalkuthe previously approved these changes Apr 15, 2023
Copy link
Member

@pascalkuthe pascalkuthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@the-mikedavis the-mikedavis changed the title Fix crash on opening from suspend state (#6725) Fix crash on opening from suspend state Apr 16, 2023
helix-term/src/application.rs Outdated Show resolved Hide resolved
helix-term/src/application.rs Outdated Show resolved Hide resolved
@h1t h1t requested a review from the-mikedavis April 16, 2023 19:50
@pascalkuthe pascalkuthe merged commit 1b016a8 into helix-editor:master Apr 16, 2023
Triton171 pushed a commit to Triton171/helix that referenced this pull request Jun 18, 2023
* Fix crash on opening from suspend state (helix-editor#6725)

* Fix code style

* revert using of the imperative code style. Add panic if couldn't set terminal raw mode

* remove redundant import of core::panic macros

* small refactoring
wes-adams pushed a commit to wes-adams/helix that referenced this pull request Jul 4, 2023
* Fix crash on opening from suspend state (helix-editor#6725)

* Fix code style

* revert using of the imperative code style. Add panic if couldn't set terminal raw mode

* remove redundant import of core::panic macros

* small refactoring
smortime pushed a commit to smortime/helix that referenced this pull request Jul 10, 2024
* Fix crash on opening from suspend state (helix-editor#6725)

* Fix code style

* revert using of the imperative code style. Add panic if couldn't set terminal raw mode

* remove redundant import of core::panic macros

* small refactoring
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helix 23.03 crashes when user tries to open it from suspended state (fg, bg)
5 participants