-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lint: snazzy #3583
lint: snazzy #3583
Conversation
@nrdxp please sanity check my choices :) |
Well, this is PR 24, you almost covered the whole first page |
Yeah, I'm done now. |
How many hours did you spend on Helix contributions today? Are you trying to make me feel bad? I did offer to close them all and make a new PR if a core member asks me to. @nrdxp sorry for derailing here, I were meaning to ask for your input on this. |
No not at all, thanks a lot for working on all of this, I just found the sheer quantity of PRs a bit funny. |
Yeah :p it became quite a bit more work than I initially intended. Does reflect the feeling I had that the themes were lacking in some details. Sorry for getting passive-aggressive. I'm tired, going to bed now. |
I think all of these could have been separate commits in a single PR? |
Yeah. Do you want me to close them and make a new one? |
If you don't mind, it would be slightly easier to review and merge |
How should I indicate changes which have already been approved by original authors? |
Moved to bulk PR #3587 |
passes linter from #3234