Themes update #3587
Themes update #3587
Conversation
|
It's done @archseer Let me know if you'd want side by side screenshots for any of them :) |
|
Thank you! I'm ok with monokai and everforest changes |
|
The penumbra changes result in the command help text being unreadable on my machine. What was the original issue the linter found with penumbra+? Maybe I can help resolve it. |
Looking at it here it has sky for bg. That's wrong isn't it? Don't know what's happened, I'll fix it to shade later tonight. Thanks! Penumbra only set fg for some fields that expects a bg. Most important were |
|
Penumbra looks better now? |
Co-authored-by: Ivan Tham <[email protected]>
Co-authored-by: Ivan Tham <[email protected]>
AlexanderBrevig
force-pushed
the
themes-update
branch
from
97bfa82
to
db31062
Compare
|
Rebased. |
|
I'm not the author of the solarized themes by the way. |
* lint: snazzy * lint: pop-dark * lint: penumbra+ * lint: noctis_bordo * lint: ingrid * lint: flatwhite * lint: doom_acario_dark * lint: dark_plus * lint: boo_berry * fix: use 47345E per author instruction * lint: bogster * lint: everforest * lint: acme * lint: serika * fix: use nasty_red per author suggestion * lint: nord * lint: dracula * lint: gruvbox * fix: cursorline gruvbox * lint: autumn * fix: no fg for cursorline * lint: ayu * lint: rose_pine * lint: monokai * lint: solarized * lint: spacebones * fix: penumbra bg!=sky * Update runtime/themes/ayu_light.toml Co-authored-by: Ivan Tham <[email protected]> * Update runtime/themes/ayu_light.toml Co-authored-by: Ivan Tham <[email protected]> * fix: fg for ui.help thanks @pickfire * fix: ingrid with input from @intarga Co-authored-by: Ivan Tham <[email protected]>
* lint: snazzy * lint: pop-dark * lint: penumbra+ * lint: noctis_bordo * lint: ingrid * lint: flatwhite * lint: doom_acario_dark * lint: dark_plus * lint: boo_berry * fix: use 47345E per author instruction * lint: bogster * lint: everforest * lint: acme * lint: serika * fix: use nasty_red per author suggestion * lint: nord * lint: dracula * lint: gruvbox * fix: cursorline gruvbox * lint: autumn * fix: no fg for cursorline * lint: ayu * lint: rose_pine * lint: monokai * lint: solarized * lint: spacebones * fix: penumbra bg!=sky * Update runtime/themes/ayu_light.toml Co-authored-by: Ivan Tham <[email protected]> * Update runtime/themes/ayu_light.toml Co-authored-by: Ivan Tham <[email protected]> * fix: fg for ui.help thanks @pickfire * fix: ingrid with input from @intarga Co-authored-by: Ivan Tham <[email protected]>
* lint: snazzy * lint: pop-dark * lint: penumbra+ * lint: noctis_bordo * lint: ingrid * lint: flatwhite * lint: doom_acario_dark * lint: dark_plus * lint: boo_berry * fix: use 47345E per author instruction * lint: bogster * lint: everforest * lint: acme * lint: serika * fix: use nasty_red per author suggestion * lint: nord * lint: dracula * lint: gruvbox * fix: cursorline gruvbox * lint: autumn * fix: no fg for cursorline * lint: ayu * lint: rose_pine * lint: monokai * lint: solarized * lint: spacebones * fix: penumbra bg!=sky * Update runtime/themes/ayu_light.toml Co-authored-by: Ivan Tham <[email protected]> * Update runtime/themes/ayu_light.toml Co-authored-by: Ivan Tham <[email protected]> * fix: fg for ui.help thanks @pickfire * fix: ingrid with input from @intarga Co-authored-by: Ivan Tham <[email protected]>
This is a collection of changes made to force themes to handle in a predictable way. It also enforces a response to enabling features (like
cursorline) so users who want these features will still see them even if they change themes.I've tried my best to stick to the spirit of the theme, but some themes relied so much on terminal colors that I just had to guess and base some assumptions from other editors with similar themes.
Status from original authors (in terms of approvals)