Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanagawa: theme rulers and some miscellaneous fixes #5571

Merged
merged 5 commits into from
Jan 19, 2023

Conversation

luetage
Copy link
Contributor

@luetage luetage commented Jan 18, 2023

This PR introduces following changes

  • Add sumiInk2 color for theming rulers – at the moment only »virtual« is set, which themes both whitespace characters and rulers. This change themes the foreground for whitespace characters and the background for rulers.
  • Dark background for menu and help – while the current version works for the command mode menu and help, these UI elements are also in use for auto-completion. Using the main background for such popups is a little confusing, because there is no border to separate menu content from main content.
  • Bold modifier for insert and select mode in statusline – normal mode already uses bold and it is a matter of taste, but I’d say it looks more consistent this way.
  • Dark foreground color for window separators – the original nvim theme seems to use a dark color, here the default foreground color is in use. Personally I think it looks best to set both foreground and background color of window separators to sumiInk0, so the separators meld with the statusline and there is no gap between statuslines of adjacent windows. But no other theme handles it this way so I didn’t do it either.

@zetashift and @leonqadirie please take a look. This is naturally all up for discussion and apart from theming the rulers none of it is addressing anything serious.

@leonqadirie
Copy link
Contributor

leonqadirie commented Jan 19, 2023

I consider @zetashift the owner here, but LGTM.
Thanks!

@zetashift
Copy link
Contributor

Ah! I see it as a community effort :P.

Thank you for these fixes, they look nice, it's a 👍 for me!

@the-mikedavis the-mikedavis merged commit 670c6b0 into helix-editor:master Jan 19, 2023
kirawi pushed a commit to kirawi/helix that referenced this pull request Jan 25, 2023
* discern between rulers and whitespace, add sumiInk2
* darker background for menu and help, bold selection
* bold modifier for insert and select
* dark color for window separator
* bring ruler, whitespace, indent-guide together
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants