-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kanagawa: fix bufferline, theme wrap-indicators, cursor, menu, and syntax changes #6085
Conversation
LGTM. Thank you! -- |
@leonqadirie Purely a matter of taste; the menu changes aren’t needed and most of the other changes aren’t essential either. If you like it, we include it, if not, I won’t be disappointed, because I can likewise run these changes just for myself. Thanks for the feedback in any case 💐 |
@luetage No, I'm with you, let's follow the original here. |
Following the original is always the better route! p.s. no need to say sorry when tagging, I very much appreciate these kinds of PRs and the work you have done. |
This is a followup to #5571
These two fixes are needed, everything that follows is miscellaneous improvements and fixes.
I found out completion menus in the original Kanagawa use waveBlue1/2 as background and implemented it
Non‐text characters (newline/nbsp) become invisible when highlighted, changed them to use sumiInk4
The primary and secondary cursor highlight are hard to distinguish, they have better contrast now for multiple selections. I also changed
cursor.match
to waveRed for the same reason.Added cursorcolumn color; this was already themed through primary cursorline, but it can’t hurt to write it down
I played around with markup modifiers, added and changed a few highlights. Comparison below:
I ordered the syntax according to documentation, made tag and label different for CSS, changed attributes to waveRed from peachRed because it was a bit aggressive in HTML, where many attributes are in use. Added a few additional highlights while trying to keep it consistent. I removed module highlight, because it isn’t mentioned in the documentation and I removed superfluous entries (e.g. for punctuation everything is one color, therefore only one entry is needed).
@zetashift and @leonqadirie: Sorry to annoy you again so soon ^^ but please have a look, if you have time. Some of this is probably biased and as mentioned earlier, only the first two points really need attention. I’m willing to throw all the other commits out should you dislike them.