Editor window size content overflows

[RohanPunjani]

After capturing the GIF, when opening the editor window, the size is not compatible with the content, and the content is overflowed.

There is a white background by default for anything that is visible outside of bounds of the window

[Pranav2612000]

@clearlysid Were you able to reproduce this? Or is it a windows only issue?

[clearlysid]

Seems like a windows-only issue. I can't create it on macOS. I'm pretty sure it has to do with the PhysicalPosition and LogicalPosition being differently handled on both platforms.

[RohanPunjani]

The height of the editor window is taken by calculating the preview height + tools height. Preview height is the height that was initially received from the encoder while encoding, but the preview video that was been sent is of always of dimension 3840x2160px

Normal 600x400 frame:

Normal 400x600 frame:

Normal 800x200 frame:

[RohanPunjani]

A fix for this is to set aspect ratio always as 3840/2160 for windows

let mut aspect_ratio = width as f32 / height as f32;

#[cfg(target_os = "windows")]
{
    aspect_ratio = 3840.00 / 2160.00;
}

let preview_height_adjusted = EDITOR_WIDTH as f32 / aspect_ratio;
let editor_win_height = preview_height_adjusted + TOOLS_HEIGHT as f32;

[RohanPunjani]

This is how it looks like now:

800 x 200	400 x 600	600 x 400

The issue was with windows-capture where the encoded video was not with proper frame dimensions, it has been fixed and also been merged now which gives the above result.