Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added custom aspect ratio for windows #91

Closed
wants to merge 1 commit into from

Conversation

RohanPunjani
Copy link
Contributor

No description provided.

@RohanPunjani RohanPunjani linked an issue May 18, 2024 that may be closed by this pull request
@clearlysid
Copy link
Collaborator

This should be fixed at a henx level directly, not here.

@RohanPunjani
Copy link
Contributor Author

This should be fixed at a henx level directly, not here.

In henx: when defining a new encoder:

let encoder = Some(
         WVideoEncoder::new(
             VideoEncoderType::Mp4,
             VideoEncoderQuality::Uhd2160p,
             options.width as u32,
             options.height as u32,
             options.path,
         )
         .expect("Failed to create video encoder"),
     );

It takes videoEncoderQuality
Below is the actual output frame dimension while running few test on the parameters of videoEncoderQuality on frame dimensions of 1280x680

Auto - Error -> Failed to create video encoder: WindowsError(Error { code: HRESULT(0xC00D36E6), message: "The requested attribute was not found." })
HD1080p - 1920 x 1080
HD720p - 1280 x 720
Wvga - 800 x 480
Ntsc - 720 x 480
Pal - 720 x 576
Vga - 640 x 480
Qvga - 320 x 240
Uhd2160p - 3840 x 2160
Uhd4320p - Error -> Failed to create video encoder: WindowsError(Error { code: HRESULT(0xC00D6D60), message: "A valid type has not been set for this stream or a stream that it depends on." })

@clearlysid
Copy link
Collaborator

Let's ask NiiightmareXD on Discord for guidance here.

@clearlysid
Copy link
Collaborator

Closing in favour of #72 and henx update.

@clearlysid clearlysid closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor window size content overflows
2 participants