Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI failures on main #757

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Fix CI failures on main #757

merged 1 commit into from
Jan 3, 2024

Commits on Jan 2, 2024

  1. Fix CI failures on main

    Fixes the following CI failures on `main`:
    1. Lint failures on the newly released Rust 1.75 (see #756)
        (plus preemptively fixes another for Rust 1.76 beta).
    2. Integration test failures due to the Ruby example having
        picked up newer bundler, which is not compatible with
        the Ruby 2.7 it uses.
    
    I've opted to delete the Ruby example entirely, since:
    1. This is currently blocking libcnb.rs PRs/development.
    2. It has multiple issues that really require a complete rewrite:
      - #398
      - #479
      - #746
      - #755
    3. IMO including a full language CNB example in this repo is
      not something we should do, since it's both never going to
      fully support the language in a best practice way, and also
      will be too complicated to demonstrate libcnb concepts in
      the simplified way that we should be using in an example.
      Instead, we should stick to simple examples of concepts,
      and then link out to our real-world CNB repos for users
      who want to do further reading.
    
    As an added bonus, the removal will speed up CI a fair amount, since
    the Ruby integration test was very slow (due to it bundler plus the test
    using a different builder image, so another docker pull).
    
    Fixes #756.
    Fixes #398.
    Fixes #479.
    Fixes #746.
    Fixes #755.
    GUS-W-14739082.
    GUS-W-14739086.
    edmorley committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    6b65923 View commit details
    Browse the repository at this point in the history