Merge pull request #1064 from hey-api/fix/client-url-encode

fix: encode path params
hey-api · Sep 19, 2024 · c39ee74 · c39ee74
2 parents bf76cb0 + 2079c6e
commit c39ee74
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 12 deletions.
diff --git a/.changeset/good-clouds-guess.md b/.changeset/good-clouds-guess.md
@@ -0,0 +1,6 @@
+---
+'@hey-api/client-axios': patch
+'@hey-api/client-fetch': patch
+---
+
+fix: encode path params
diff --git a/packages/client-axios/src/utils.ts b/packages/client-axios/src/utils.ts
@@ -241,10 +241,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => {
         continue;
       }
 
-      url = url.replace(
-        match,
+      const replaceValue = encodeURIComponent(
         style === 'label' ? `.${value as string}` : (value as string),
       );
+      url = url.replace(match, replaceValue);
     }
   }
   return url;

diff --git a/packages/client-fetch/src/utils.ts b/packages/client-fetch/src/utils.ts
@@ -253,10 +253,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => {
         continue;
       }
 
-      url = url.replace(
-        match,
+      const replaceValue = encodeURIComponent(
         style === 'label' ? `.${value as string}` : (value as string),
       );
+      url = url.replace(match, replaceValue);
     }
   }
   return url;

diff --git a/...pi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle/core/utils.ts.snap b/...pi-ts/test/__snapshots__/test/generated/v3-hey-api-client-axios-bundle/core/utils.ts.snap
@@ -241,10 +241,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => {
         continue;
       }
 
-      url = url.replace(
-        match,
+      const replaceValue = encodeURIComponent(
         style === 'label' ? `.${value as string}` : (value as string),
       );
+      url = url.replace(match, replaceValue);
     }
   }
   return url;

diff --git a/.../__snapshots__/test/generated/v3-hey-api-client-axios-bundle_transform/core/utils.ts.snap b/.../__snapshots__/test/generated/v3-hey-api-client-axios-bundle_transform/core/utils.ts.snap
@@ -241,10 +241,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => {
         continue;
       }
 
-      url = url.replace(
-        match,
+      const replaceValue = encodeURIComponent(
         style === 'label' ? `.${value as string}` : (value as string),
       );
+      url = url.replace(match, replaceValue);
     }
   }
   return url;

diff --git a/...pi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/core/utils.ts.snap b/...pi-ts/test/__snapshots__/test/generated/v3-hey-api-client-fetch-bundle/core/utils.ts.snap
@@ -253,10 +253,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => {
         continue;
       }
 
-      url = url.replace(
-        match,
+      const replaceValue = encodeURIComponent(
         style === 'label' ? `.${value as string}` : (value as string),
       );
+      url = url.replace(match, replaceValue);
     }
   }
   return url;

diff --git a/.../__snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/core/utils.ts.snap b/.../__snapshots__/test/generated/v3-hey-api-client-fetch-bundle_transform/core/utils.ts.snap
@@ -253,10 +253,10 @@ const defaultPathSerializer = ({ path, url: _url }: PathSerializer) => {
         continue;
       }
 
-      url = url.replace(
-        match,
+      const replaceValue = encodeURIComponent(
         style === 'label' ? `.${value as string}` : (value as string),
       );
+      url = url.replace(match, replaceValue);
     }
   }
   return url;