Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: encode path params #1064

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: encode path params #1064

merged 1 commit into from
Sep 19, 2024

Conversation

mrlubos
Copy link
Member

@mrlubos mrlubos commented Sep 19, 2024

Closes #1040

Copy link

stackblitz bot commented Sep 19, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Sep 19, 2024

🦋 Changeset detected

Latest commit: 2079c6e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@hey-api/client-axios Patch
@hey-api/client-fetch Patch
@example/openapi-ts-axios Patch
@example/openapi-ts-fetch Patch
@example/openapi-ts-tanstack-react-query Patch
@example/openapi-ts-tanstack-svelte-query Patch
@example/openapi-ts-tanstack-vue-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mrlubos mrlubos marked this pull request as ready for review September 19, 2024 07:39
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hey-api-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 19, 2024 7:43am

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.56%. Comparing base (bf76cb0) to head (2079c6e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1064   +/-   ##
=======================================
  Coverage   76.56%   76.56%           
=======================================
  Files         103      103           
  Lines       11268    11268           
  Branches     1135     1135           
=======================================
  Hits         8627     8627           
  Misses       2634     2634           
  Partials        7        7           
Flag Coverage Δ
unittests 76.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

pkg-pr-new bot commented Sep 19, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/@hey-api/client-axios@1064
pnpm add https://pkg.pr.new/@hey-api/client-fetch@1064
pnpm add https://pkg.pr.new/@hey-api/openapi-ts@1064

commit: 2079c6e

@mrlubos mrlubos merged commit c39ee74 into main Sep 19, 2024
17 checks passed
@mrlubos mrlubos deleted the fix/client-url-encode branch September 19, 2024 07:51
@github-actions github-actions bot mentioned this pull request Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parameter in path with multiple dollar sign gets replaced to a single dollar sign
1 participant