Always return a str when using hv.Dimension.pprint_value (#5383)

holoviz · Aug 9, 2022 · 3424cd7 · 3424cd7
1 parent 67f1fcf
commit 3424cd7
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/holoviews/core/dimension.py b/holoviews/core/dimension.py
@@ -416,7 +416,7 @@ def pprint_value(self, value, print_unit=False):
                 else:
                     formatted_value = formatter % value
         else:
-            formatted_value = bytes_to_unicode(value)
+            formatted_value = str(bytes_to_unicode(value))
 
         if print_unit and self.unit is not None:
             formatted_value = formatted_value + ' ' + bytes_to_unicode(self.unit)

diff --git a/holoviews/tests/core/test_dimensions.py b/holoviews/tests/core/test_dimensions.py
@@ -77,6 +77,12 @@ def test_name_dimension_repr_params_eval_equality(self):
         dim = Dimension('test', label='Test Dimension', unit='m')
         self.assertEqual(eval(repr(dim)) == dim, True)
 
+    def test_pprint_value_boolean(self):
+        # https://github.com/holoviz/holoviews/issues/5378
+        dim = Dimension('test')
+        self.assertEqual(dim.pprint_value(True), 'True')
+        self.assertEqual(dim.pprint_value(False), 'False')
+
 
 class DimensionEqualityTest(ComparisonTestCase):