Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always return a str when using hv.Dimension.pprint_value #5383

Merged
merged 1 commit into from
Aug 9, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Aug 9, 2022

Fixes #5378

@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #5383 (0d34c0b) into master (ad59a3f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5383   +/-   ##
=======================================
  Coverage   88.07%   88.07%           
=======================================
  Files         301      301           
  Lines       61965    61969    +4     
=======================================
+ Hits        54575    54579    +4     
  Misses       7390     7390           
Impacted Files Coverage Δ
holoviews/core/dimension.py 86.42% <100.00%> (ø)
holoviews/tests/core/test_dimensions.py 99.53% <100.00%> (+<0.01%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@philippjfr
Copy link
Member

Looks good!

@philippjfr philippjfr merged commit 3424cd7 into master Aug 9, 2022
@philippjfr philippjfr deleted the hoxbro/pprint_boolean branch August 9, 2022 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rendering an NdOverlay with bool kdim raises TypeError
3 participants