Skip to content

Commit

Permalink
Handle warnings from tests and remove ipykernel and fsspec pins (#5649)
Browse files Browse the repository at this point in the history
  • Loading branch information
hoxbro authored May 4, 2023
1 parent 7be3a7f commit 8d4cf0a
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 15 deletions.
8 changes: 0 additions & 8 deletions holoviews/tests/plotting/test_comms.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,11 +54,3 @@ def test_decode(self):
msg = {'content': {'data': 'Test'}}
decoded = JupyterComm.decode(msg)
self.assertEqual(decoded, 'Test')

def test_on_msg(self):
def raise_error(msg):
if msg == 'Error':
raise Exception()
comm = JupyterComm(id='Test', on_msg=raise_error)
with self.assertRaises(Exception):
comm._handle_msg({'content': {'data': 'Error'}})
2 changes: 2 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ filterwarnings = [
"ignore:`.+?` is a deprecated alias for `.+?`.:DeprecationWarning:skimage.util.dtype", # https://github.com/scikit-image/scikit-image/pull/6637
# 2023-01: Sqlalchemy 2.0 warning:
"ignore: Deprecated API features detected:DeprecationWarning:ibis.backends.base.sql.alchemy", # https://github.com/ibis-project/ibis/issues/5048
# 2023-03: Already handling the nested sequence
"ignore:Creating an ndarray from ragged nested sequences:numpy.VisibleDeprecationWarning:holoviews.core.data.spatialpandas"
]

[tool.ruff]
Expand Down
7 changes: 0 additions & 7 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,6 @@
'dash >=1.16',
'codecov',
'ipython >=5.4.0',
# Issues with comm (see https://github.com/ipython/ipykernel/issues/1026)
'ipykernel <6.18.0',
]

# Optional tests dependencies, i.e. one should be able
Expand Down Expand Up @@ -108,11 +106,6 @@
"datashader >=0.11.1",
]

if sys.version_info < (3, 8):
extras_require["tests"] += [
"fsspec == 2023.1",
]


extras_require["examples_tests"] = extras_require["examples"] + extras_require['tests_nb']

Expand Down

0 comments on commit 8d4cf0a

Please sign in to comment.