Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle warnings from tests and remove ipykernel and fsspec pins #5649

Merged
merged 7 commits into from
May 4, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 8, 2023

  • The nested array warning is coming from here, so it can safely be ignored
    try:
    return np.asarray(v)
    except ValueError:
    return np.asarray(v, dtype=object)
  • The unpin of ipykernel makes the deleted test fail, though when running it with Ipykernel <6.18, it passes because a different error is raised and not the one tested for. I have therefore deleted the test.
    from pyviz_comms import JupyterComm
    
    
    def raise_error(msg):
        if msg == 'Error':
            raise Exception()
    
    comm = JupyterComm(id='Test', on_msg=raise_error)
    comm._handle_msg({'content': {'data': 'Error'}})
    image

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2023

Codecov Report

Merging #5649 (ec430cc) into main (7be3a7f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #5649   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files         302      302           
  Lines       62633    62626    -7     
=======================================
- Hits        55307    55302    -5     
+ Misses       7326     7324    -2     
Impacted Files Coverage Δ
holoviews/tests/plotting/test_comms.py 100.00% <ø> (+4.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro changed the title Handle warnings from tests and remove ipyrkenel pin Handle warnings from tests and remove ipykernel pin Mar 8, 2023
@hoxbro hoxbro changed the title Handle warnings from tests and remove ipykernel pin Handle warnings from tests and remove ipykernel and fsspec pins May 4, 2023
@hoxbro hoxbro merged commit 8d4cf0a into main May 4, 2023
@hoxbro hoxbro deleted the ci_updates branch May 4, 2023 10:42
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants