Don't load any html in the notebook when no logo is required #5216
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5216 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 298 298
Lines 62162 62162
=======================================
Hits 53929 53929
Misses 8233 8233
Continue to review full report at Codecov.
|
|
Two checks were cancelled because they timed out after 1hr. Looking forward to the new libmamba solver to speed things up, and maybe the caching Mridul has started to implement in hvPlot. |
holoviews/ipython/__init__.py
Outdated
| @@ -194,7 +194,7 @@ def __call__(self, *args, **params): | |||
| "hv-extension-comm") | |||
|
|
|||
| # Create a message for the logo (if shown) | |||
| if not same_cell_execution: | |||
| if not same_cell_execution and p.logo: | |||
| self.load_hvjs(logo=p.logo, | |||
There was a problem hiding this comment.
Given that panel handles the JS now, I guess this is now misnamed (an artifact of history). Could you double check it is only used to load HTML and if so, rename it to self.load_extension_html (or similar)?
|
Looks good to me! |
This avoids calling
publish_display_datain a notebook when callinghv.extension()withlogo=Falsebecause unfortunately in JupyterLab each call topublish_display_dataends up adding an empty line.The call to
publish_display_dataloads HTML from theload_notebook.htmltemplate which only contains the logos base64 encoded. So it seems safe to avoid loading this HTML when no logo is required.