Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't load any html in the notebook when no logo is required #5216

Merged
merged 3 commits into from
Mar 31, 2022
Merged

Don't load any html in the notebook when no logo is required #5216

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6a704d3
don't load html in the notebook when no logo is required
maximlt Feb 21, 2022
675610c
Merge branch 'master' into dont_load_when_nologo
maximlt Mar 31, 2022
3420527
rename load_hvjs to load_logo and remove unused parameters
maximlt Mar 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion holoviews/ipython/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def __call__(self, *args, **params):
"hv-extension-comm")

# Create a message for the logo (if shown)
if not same_cell_execution:
if not same_cell_execution and p.logo:
self.load_hvjs(logo=p.logo,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that panel handles the JS now, I guess this is now misnamed (an artifact of history). Could you double check it is only used to load HTML and if so, rename it to self.load_extension_html (or similar)?

bokeh_logo= p.logo and ('bokeh' in resources),
mpl_logo= p.logo and (('matplotlib' in resources)
Expand Down