Update to compatibility with latest param.rx API #5918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5918 +/- ##
===========================================
- Coverage 88.42% 23.27% -65.16%
===========================================
Files 313 313
Lines 65160 65156 -4
===========================================
- Hits 57619 15162 -42457
- Misses 7541 49994 +42453
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 297 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Apologies for merging without tests passing but there's a bunch of blockers that currently prevent building working Panel packages that would allow the test suite to pass and this change is trivial. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
param2.0.0rc6 changed the API for getting the current value of an rx object to
.rx.value