Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace _ignored_refs with explicit allow_refs #5565

Merged
merged 4 commits into from
Oct 3, 2023
Merged

Conversation

philippjfr
Copy link
Member

Use allow_refs definitions as ultimate source of truth for enabling/disabling allow_refs.

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #5565 (8cf5a70) into main (bf09830) will decrease coverage by 42.66%.
Report is 2 commits behind head on main.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##             main    #5565       +/-   ##
===========================================
- Coverage   83.26%   40.61%   -42.66%     
===========================================
  Files         277      277               
  Lines       39601    39578       -23     
===========================================
- Hits        32975    16075    -16900     
- Misses       6626    23503    +16877     
Flag Coverage Δ
ui-tests 40.61% <50.00%> (-0.03%) ⬇️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/config.py 54.98% <100.00%> (-14.26%) ⬇️
panel/pane/base.py 58.28% <100.00%> (-26.25%) ⬇️
panel/pane/holoviews.py 15.85% <ø> (-63.47%) ⬇️
panel/pane/ipywidget.py 48.75% <ø> (-0.64%) ⬇️
panel/pane/plot.py 41.73% <ø> (-27.10%) ⬇️
panel/param.py 24.40% <ø> (-61.17%) ⬇️
panel/pipeline.py 13.29% <ø> (-75.51%) ⬇️
panel/reactive.py 40.62% <100.00%> (-39.48%) ⬇️
panel/widgets/indicators.py 36.36% <ø> (-37.45%) ⬇️
panel/widgets/misc.py 56.29% <ø> (-36.36%) ⬇️
... and 1 more

... and 190 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member Author

Remaining failures are resolved in holoviz/holoviews#5918

@philippjfr philippjfr merged commit bec9f2f into main Oct 3, 2023
7 of 14 checks passed
@philippjfr philippjfr deleted the remove_ignored_refs branch October 3, 2023 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant