Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't pin notebook in conda receipe for pyviz #6108

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 12, 2024

Recommended was added to the pyviz conda.receipe, giving a weird solve for hvplot CI, because another dependency had likely pinned notebook <7

@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Feb 12, 2024
@hoxbro hoxbro enabled auto-merge (squash) February 12, 2024 09:01
@hoxbro hoxbro changed the title Move notebook pin Don't pin notebook in conda receipe for pyviz Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9ac5d35) 88.53% compared to head (fd3c374) 88.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6108      +/-   ##
==========================================
+ Coverage   88.53%   88.66%   +0.13%     
==========================================
  Files         314      314              
  Lines       65982    65982              
==========================================
+ Hits        58414    58504      +90     
+ Misses       7568     7478      -90     
Flag Coverage Δ
ui-tests 23.67% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit b639f17 into main Feb 12, 2024
12 checks passed
@hoxbro hoxbro deleted the move_notebook_pin branch February 12, 2024 09:55
hoxbro added a commit that referenced this pull request Feb 12, 2024
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants