Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link selection for empty Layout #6110

Merged
merged 2 commits into from
Feb 12, 2024
Merged

Fix link selection for empty Layout #6110

merged 2 commits into from
Feb 12, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Feb 12, 2024

Fixes #6106

(Needs #6108 to be merged before release)

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b639f17) 88.68% compared to head (d4ec355) 88.70%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6110      +/-   ##
==========================================
+ Coverage   88.68%   88.70%   +0.02%     
==========================================
  Files         314      314              
  Lines       65982    65993      +11     
==========================================
+ Hits        58514    58537      +23     
+ Misses       7468     7456      -12     
Flag Coverage Δ
ui-tests 23.67% <16.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro enabled auto-merge (squash) February 12, 2024 10:06
@hoxbro hoxbro merged commit bde86c3 into main Feb 12, 2024
12 checks passed
@hoxbro hoxbro deleted the fix_link_selection_empty branch February 12, 2024 10:52
hoxbro added a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

KeyError raised when using combination of checkbox, interactive dataframe, linked_selections, and hover_cols.
2 participants