Improve the open commissioning window command #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if the commissioning window is indeed open before returning cached values. This is to prevent returning stale values when the commissioning window got closed, either because the device got successfully commissioned with another network or because the commissioning window got closed due to an error in attempting to commission. Especially the latter case leads to very bad user experience as folks try to use the stale (non-working) commissioning code for the next 10 minutes and get frustrated.
agners
added
the
maintenance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check if the commissioning window is indeed open before returning cached values. This is to prevent returning stale values when the commissioning window got closed, either because the device got successfully commissioned with another network or because the commissioning window got closed due to an error in attempting to commission. Especially the latter case leads to very bad user experience as folks try to use the stale (non-working) commissioning code for the next 10 minutes and get frustrated.
While at it, also close the commissioning window if someone else opened it and we can't provide credentials.