Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the open commissioning window command #752

Merged
merged 1 commit into from
Jun 13, 2024

Commits on Jun 13, 2024

  1. Improve the open commissioning window command

    Check if the commissioning window is indeed open before returning
    cached values. This is to prevent returning stale values when the
    commissioning window got closed, either because the device got
    successfully commissioned with another network or because the
    commissioning window got closed due to an error in attempting to
    commission. Especially the latter case leads to very bad user
    experience as folks try to use the stale (non-working) commissioning
    code for the next 10 minutes and get frustrated.
    agners committed Jun 13, 2024
    Configuration menu
    Copy the full SHA
    55a1c8f View commit details
    Browse the repository at this point in the history