Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add analytics insights #5073

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Add analytics insights #5073

merged 2 commits into from
Jan 23, 2024

Conversation

joostlek
Copy link
Member

Proposed change

Add homeassistant analytics

Type of change

  • Add a new logo or icon for a new core integration
  • Add a missing icon or logo for an existing core integration
  • Add a new logo or icon for a custom integration (custom component)
  • Replace an existing icon or logo with a higher quality version
  • Removing an icon or logo

Additional information

Checklist

  • The added/replaced image(s) are PNG
  • Icon image size is 256x256px (icon.png)
  • hDPI icon image size is 512x512px for ([email protected])
  • Logo image size has min 128px, but max 256px, on the shortest side (logo.png)
  • hDPI logo image size has min 256px, but max 512px, on the shortest side ([email protected])

@frenck frenck added the has-parent This PR has a parent PR in a other repo label Jan 14, 2024
frenck
frenck previously approved these changes Jan 14, 2024
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved. Can be merged as soon as the parent PR gets merged.

@frenck frenck added the awaits-parent Awaits the merge of an parent PR label Jan 14, 2024
Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adjust the domain name as the domain was changed in core

@home-assistant home-assistant bot marked this pull request as draft January 18, 2024 20:18
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@joostlek joostlek changed the title Add homeassistant analytics Add analytics insights Jan 19, 2024
@joostlek joostlek marked this pull request as ready for review January 19, 2024 09:44
@frenck frenck merged commit 7b906e5 into home-assistant:master Jan 23, 2024
5 checks passed
@joostlek joostlek deleted the haa branch January 23, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaits-parent Awaits the merge of an parent PR has-parent This PR has a parent PR in a other repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants