-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Homeassistant Analytics Insights integration #107634
Add Homeassistant Analytics Insights integration #107634
Conversation
homeassistant/components/homeassistant_analytics/config_flow.py
Outdated
Show resolved
Hide resolved
homeassistant/components/homeassistant_analytics/coordinator.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cant wait
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a really useful thing!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments from some of my recent work.
Looks GREAT!
homeassistant/components/homeassistant_analytics/coordinator.py
Outdated
Show resolved
Hide resolved
homeassistant/components/homeassistant_analytics/config_flow.py
Outdated
Show resolved
Hide resolved
homeassistant/components/homeassistant_analytics/config_flow.py
Outdated
Show resolved
Hide resolved
homeassistant/components/homeassistant_analytics/config_flow.py
Outdated
Show resolved
Hide resolved
step_id="user", | ||
data_schema=vol.Schema( | ||
{ | ||
vol.Required(CONF_TRACKED_INTEGRATIONS): SelectSelector( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an option flow so the user can change the tracked integrations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in a follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me, just the single thing :)
homeassistant/components/homeassistant_analytics_consumer/manifest.json
Outdated
Show resolved
Hide resolved
…fest.json Co-authored-by: Sid <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
Co-authored-by: Robert Resch <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @joostlek 👍
* Add Homeassistant Analytics integration * Add Homeassistant Analytics integration * Add Homeassistant Analytics integration * Fix feedback * Fix test * Update conftest.py * Add some testcases * Make code clear * log exception * Bump python-homeassistant-analytics to 0.2.1 * Bump python-homeassistant-analytics to 0.3.0 * Change domain to homeassistant_analytics_consumer * Add integration name to config flow selector * Update homeassistant/components/homeassistant_analytics_consumer/manifest.json Co-authored-by: Sid <[email protected]> * Fix hassfest * Apply suggestions from code review Co-authored-by: Robert Resch <[email protected]> * Bump python-homeassistant-analytics to 0.4.0 * Rename to Home Assistant Analytics Insights * Update homeassistant/components/analytics_insights/config_flow.py Co-authored-by: Robert Resch <[email protected]> * Update homeassistant/components/analytics_insights/manifest.json Co-authored-by: Robert Resch <[email protected]> * Rename to Home Assistant Analytics Insights * add test * Fallback to 0 when there is no data found * Allow to select any integration * Fix tests * Fix tests * Update tests/components/analytics_insights/conftest.py Co-authored-by: Robert Resch <[email protected]> * Update tests/components/analytics_insights/test_sensor.py Co-authored-by: Robert Resch <[email protected]> * Fix format * Fix tests --------- Co-authored-by: Sid <[email protected]> Co-authored-by: Robert Resch <[email protected]>
Proposed change
As developer, have you ever wanted to automate your firework when you reach a new all time user high in your integration? Do you like to see the impact on the installations when Frenck mentions your efforts in the release notes?
Wait no more! With this brand spanking new integration you can integrate home assistant analytics into home assistant. Well, you can even track home assistant analytics usage in home assistant analytics. If that doesn't sound good, I don't know what does.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: