-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress log warnings when a sensor group has non numeric members #102828
Suppress log warnings when a sensor group has non numeric members #102828
Conversation
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Oops looks like there's some test updates I didn't catch. |
I'm guessing the failed code coverage check was just a transient error but I'm unable to restart the job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this a breaking change? Given that the mode
parameter has now been redefined as ignore_non_numeric
with different logic, is it likely that a template
is now assuming the mode
logic?
Hm...not sure I follow. With regards to the
is equivalent to
I don't understand how a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial comments
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
That CI failure seems to be unrelated to the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor changes in tests then this should be fine to go 👍
… "ignore non numeric" option is selected.
…non numeric function
Co-authored-by: G Johansson <[email protected]>
- Restore `_mode` to original name - Update test case and group names - Assert that non numeric doesn't generate any warning in the logs
Co-authored-by: G Johansson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mill1000 👍
Thank you! |
Breaking change
None
Proposed change
Suppress log warnings from sensor groups that have non-numeric members and have been configured to ignore said non-numeric values
Type of change
Additional information
Checklist
black --fast homeassistant tests
)To help with the load of incoming pull requests: