Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suppress log warnings when a sensor group has non numeric members #102828

Merged
merged 8 commits into from
Jan 31, 2024
Merged

Suppress log warnings when a sensor group has non numeric members #102828

merged 8 commits into from
Jan 31, 2024

Commits on Jan 30, 2024

  1. Suppress log warnings when a sensor group has non numeric members and… 

    … "ignore non numeric" option is selected.
    @mill1000
    mill1000 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    bc85a8e View commit details
    Browse the repository at this point in the history

  2. Fix and update test cases for sensor group to better test the ignore … 

    …non numeric function
    @mill1000
    mill1000 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1e3cce5 View commit details
    Browse the repository at this point in the history

  3. Fix gibberish in test docstring

    @mill1000
    mill1000 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1627b59 View commit details
    Browse the repository at this point in the history

  4. Update tests/components/group/test_sensor.py 

    Co-authored-by: G Johansson <[email protected]>
    @mill1000 @gjohansson-ST
    mill1000 and gjohansson-ST committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    1013710 View commit details
    Browse the repository at this point in the history

  5. Restore mode members per review

    @mill1000
    mill1000 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    17441ff View commit details
    Browse the repository at this point in the history

  6. Address review comments. 

    - Restore `_mode` to original name
- Update test case and group names
- Assert that non numeric doesn't generate any warning in the logs
    @mill1000
    mill1000 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    e1261bd View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Co-authored-by: G Johansson <[email protected]>
    @mill1000 @gjohansson-ST
    mill1000 and gjohansson-ST committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    73bcb8c View commit details
    Browse the repository at this point in the history

  8. Fix formatting violations

    @mill1000
    mill1000 committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    fb177f7 View commit details
    Browse the repository at this point in the history