-
-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coordinator to ring integration #107088
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
2bcc229
to
2fc6c1f
Compare
Now updated as per all suggestions/comments |
Please mark it ready to review after #107088 (comment) is addressed |
Now ready for review again. Service re-instated and deprecation added to #108781. |
Latest comments addressed. CI failed due to coverage upload which should be transient. |
0fcaf22
to
698da4b
Compare
Review comment addressed. |
Hi @edenhaus, hopefully all comments addressed here? Was hoping to get this into beta if possible. |
@sdb9696 Please answer my question above otherwise the PR looks fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sdb9696 👍
Can be merged if CI is passing
Thanks for all your help @edenhaus! |
N.B. The PR to prepare the ring |
Proposed change
Replace bespoke
DataUpdater
classes withDataUpdateCoordinator
derived classes from helpers.update_coordinator.This will prevent errors spamming the logs in error conditions and should get the integration quality to silver (and then gold once test coverage is improved elsewhere.)
It's also a dependency for a subsequent PR to address issue #88705.
Type of change
Additional information
The change consolidates 3 of the DataUpdater classes into 1 DataUpdateCoordinator class. This will prevent 3 seperate log messages if the api is unavailable and also makes the code simpler.
The NotificationUpdateCoordinator will be replaced with a Push listener in a subsequent change.
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: