Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare ring update service for deprecation #108781

Merged
merged 3 commits into from
Mar 11, 2024

Conversation

sdb9696
Copy link
Contributor

@sdb9696 sdb9696 commented Jan 24, 2024

Proposed change

Prepare ring.update service for deprecation once the DataUpdateCoordinator is added as per #107088. Will raise an issue and notify the service will be deprecated in 2024.7.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@sdb9696 sdb9696 changed the title Deprecate ring update service Prepare ring update service for deprecation Jan 31, 2024
@sdb9696 sdb9696 marked this pull request as ready for review January 31, 2024 10:13
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sdb9696 👍

@gjohansson-ST gjohansson-ST merged commit 48cb09a into home-assistant:dev Mar 11, 2024
21 checks passed
@sdb9696
Copy link
Contributor Author

sdb9696 commented Mar 11, 2024

Many thanks @gjohansson-ST!

@sdb9696 sdb9696 deleted the deprecate_update_service branch March 11, 2024 14:27
@github-actions github-actions bot locked and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants